Skip to content

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented May 27, 2025

Just using the dedicated method more

@rustbot
Copy link
Collaborator

rustbot commented May 27, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 27, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 27, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in exhaustiveness checking

cc @Nadrieril

@rust-log-analyzer

This comment has been minimized.

@crlf0710 crlf0710 changed the title Use builin_index instead of hand-rolling it Use builtin_index instead of hand-rolling it May 27, 2025
@rust-log-analyzer

This comment has been minimized.

@lcnr
Copy link
Contributor

lcnr commented May 27, 2025

r=me after CI? weird error

@oli-obk oli-obk closed this May 27, 2025
@oli-obk oli-obk reopened this May 27, 2025
@rust-log-analyzer

This comment has been minimized.

@oli-obk
Copy link
Contributor Author

oli-obk commented May 28, 2025

@bors r=lcnr rollup

@bors
Copy link
Collaborator

bors commented May 28, 2025

📌 Commit 550aed8 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2025
bors added a commit that referenced this pull request May 29, 2025
Rollup of 16 pull requests

Successful merges:

 - #136429 (GCI: At their def site, actually wfcheck the where-clause & always eval free lifetime-generic constants)
 - #138139 (Emit warning while outputs is not exe and prints linkage info)
 - #141104 (Test(fs): Fix `test_eq_windows_file_type` for Windows 7)
 - #141477 (Path::with_extension: show that it adds an extension where one did no…)
 - #141533 (clean up old rintf leftovers)
 - #141612 (Call out possibility of invariant result in variance markers)
 - #141638 (Use `builtin_index` instead of hand-rolling it)
 - #141643 (ci: verify that codebuild jobs use ghcr.io)
 - #141675 (Reorder `ast::ItemKind::{Struct,Enum,Union}` fields.)
 - #141680 (replace TraitRef link memory.md)
 - #141682 (interpret/allocation: Fixup type for `alloc_bytes`)
 - #141683 (Handle ed2021 precise capturing of unsafe binder)
 - #141684 (rustbook: Bump versions of `onig` and `onig_sys`)
 - #141687 (core: unstably expose atomic_compare_exchange so stdarch can use it)
 - #141690 (Add `rustc_diagnostic_item` to `sys::Mutex` methods)
 - #141702 (Add eholk to compiler reviewer rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d3a6963 into rust-lang:master May 29, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 29, 2025
rust-timer added a commit that referenced this pull request May 29, 2025
Rollup merge of #141638 - oli-obk:builtin-index, r=lcnr

Use `builtin_index` instead of hand-rolling it

Just using the dedicated method more
flip1995 pushed a commit to flip1995/rust that referenced this pull request May 31, 2025
Use `builtin_index` instead of hand-rolling it

Just using the dedicated method more
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jun 2, 2025
Rollup of 16 pull requests

Successful merges:

 - rust-lang/rust#136429 (GCI: At their def site, actually wfcheck the where-clause & always eval free lifetime-generic constants)
 - rust-lang/rust#138139 (Emit warning while outputs is not exe and prints linkage info)
 - rust-lang/rust#141104 (Test(fs): Fix `test_eq_windows_file_type` for Windows 7)
 - rust-lang/rust#141477 (Path::with_extension: show that it adds an extension where one did no…)
 - rust-lang/rust#141533 (clean up old rintf leftovers)
 - rust-lang/rust#141612 (Call out possibility of invariant result in variance markers)
 - rust-lang/rust#141638 (Use `builtin_index` instead of hand-rolling it)
 - rust-lang/rust#141643 (ci: verify that codebuild jobs use ghcr.io)
 - rust-lang/rust#141675 (Reorder `ast::ItemKind::{Struct,Enum,Union}` fields.)
 - rust-lang/rust#141680 (replace TraitRef link memory.md)
 - rust-lang/rust#141682 (interpret/allocation: Fixup type for `alloc_bytes`)
 - rust-lang/rust#141683 (Handle ed2021 precise capturing of unsafe binder)
 - rust-lang/rust#141684 (rustbook: Bump versions of `onig` and `onig_sys`)
 - rust-lang/rust#141687 (core: unstably expose atomic_compare_exchange so stdarch can use it)
 - rust-lang/rust#141690 (Add `rustc_diagnostic_item` to `sys::Mutex` methods)
 - rust-lang/rust#141702 (Add eholk to compiler reviewer rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants